Avoid wiping quickfix list on `:RescriptFormat`

Open
#52 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
vim
Domain
tooling

Research direction

Start in autoload/rescript.vim at the linked line around 164 and trace how :RescriptFormat updates the quickfix list. Check whether the same behavior occurs for :RescriptBuild. Done means formatting and building no longer wipe unrelated user quickfix entries, using the quickfix IDs approach suggested in the issue.

Written by the indexing model from the issue text.

Description

(This probably applies to the :RescriptBuild command as well)

On format, the users quickfix list should not be wiped, since it can be a list of stuff unrelated to Rescript.

Currently, it is getting wiped here:
https://github.com/rescript-lang/vim-rescript/blob/08de54132587131e762b036c11e0e9a9603992fa/autoload/rescript.vim#L164

I think this should be achievable using quickfix IDs.

Thanks

Dominant language
Vim Script
Stars
164
Forks
17
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rescript-lang/vim-rescript

All issues in rescript-lang/vim-rescript

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.