replicatedhq/ship

shipapps: HelmValues step should have customizable output path

Open

#857 opened on Mar 11, 2019

 (0 comments) (0 reactions) (0 assignees)Go (68 forks)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (635 stars)
PR merge metrics
 (PR metrics pending)

Description

Right now the YAML schema for HelmValues allows setting the source path for the values.yaml file, but it always writes the saved values to .ship/tmp/values.yaml (and in state.json). It would be great if there was a field on the HelmValues step that allowed a configurable output path.

this could be used like

---
assets:
  v1: []

config:
  v1: []

lifecycle:
  v1:
    - render:
        root: ./
        assets:
          v1:
            - github:
                dest: ./installer/consul
                repo: helm/charts
                path: stable/consul
                ref: master
                strip_path: true
    - helmValues:
        path: installer/consul/values.yaml
        dest: installer/consul/custom-values.yaml # dest is not a field today
    - render:
        root: ./
        assets:
          v1:
            - helm:
                dest: ./installer/base
                local:
                  chart_root: ./installer/consul
                values_from:
                  path: installer/consul/custom-values.yaml # use the dest from above
    - kustomize:
        base: installer/base
        dest: installer/rendered.yaml

Contributor guide