renovatebot/renovate

Feature request: Rushjs monorepo support

Open

#3681 opened on May 14, 2019

View on GitHub
 (45 comments) (31 reactions) (0 assignees)TypeScript (14,066 stars) (1,916 forks)batch import
help wantedmanager:npmmend:customer-requestpriority-4-low

Description

What would you like Renovate to be able to do? We have recently moved to a monorepo managed by Rushjs. Rush is similar to yarn workspaces, and projects are defined by entries in a top-level rush.json file. Currently it seems that there's some manual work to update rush lockfiles, and it would be great if renovate did this out of the box.

Describe the solution you'd like Enable renovate to work with rushjs monorepos. Perhaps custom lockfile logic could occur when detecting a project with a top-level rush.json file and a common/ folder.

Describe alternatives you've considered We might be able to handle lockfile updating ourselves, with a custom CI runner that builds and updates the lockfile.

Additional context We experienced this with the Fusion.js codebase after we migrated to a monorepo. We saw that renovate was opening up Pull Requests, but not updating the common lockfile.

Contributor guide

Tech stack
typescript
Domain
toolingbuild system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
RushJS monorepoRenovate internalsTypeScriptdependency management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Start by examining how Renovate currently handles other package managers like yarn and npm in the 'lib/manager' directory. Look at the structure for rush.json detection and lockfile handling. The issue references a 'common/config/rush/yarn.lock' path; investigate how to integrate Rush's lockfile logic. Review comments in the issue for any maintainer guidance or community discussion on implementation approaches. Consider starting with a proof of concept that adds rush.json detection and a minimal lockfile update routine.