renovatebot/renovate

Support vendored major upgrades for Go

Open

#21010 opened on Mar 17, 2023

View on GitHub
 (9 comments) (20 reactions) (0 assignees)TypeScript (14,066 stars) (1,916 forks)batch import
help wantedmanager:gomodpriority-3-medium

Description

What would you like Renovate to be able to do?

Update major versions in projects that have Go vendoring enabled.

Eg. github.com/google/go-github/v48 to github.com/google/go-github/v50

Reproduction repository: https://gitlab.com/hugoboos/renovate-go-update-import

Related discussion: https://github.com/renovatebot/renovate/discussions/20996

If you have any ideas on how this should be implemented, please tell us here.

At the moment Renovate updates go.mod. This should be done by the mod tool. This tool is already being used by Renovate. Only the order should be changed.

  1. Run mod to change the import paths
  2. Run go mod tidy, this will update go.mod. Possible that version is different from that Renovate selected.
  3. Change the version in go.mod for the updated package.
  4. Run go mod tidy
  5. Run go mod vendor
  6. Commit

Is this a feature you are interested in implementing yourself?

No

Contributor guide

Tech stack
gotypescript
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Go module versioningFamiliarity with Renovate codebaseExperience with Go vendoring
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the Renovate source code for the Go module manager (likely under lib/modules/manager/gomod). Understand how the 'mod' tool currently updates import paths. Implement the proposed order: run mod to change import paths, then go mod tidy, adjust version in go.mod, run go mod tidy again, then go mod vendor, and commit. Reference the reproduction repository at https://gitlab.com/hugoboos/renovate go update import and the related discussion at https://github.com/renovatebot/renovate/discussions/20996 for testing.