Go module under GitLab subgroup is not detected when GOPROXY is not set · renovatebot/renovate#16743

(4 comments) (9 reactions) (0 assignees)TypeScript (14,066 stars) (1,916 forks)batch import

datasource:gohelp wantedpriority-4-low

Description

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

32.122.6

Please select which platform you are using if self-hosting.

Local Fedora 33

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

I found it during testing https://github.com/renovatebot/renovate/pull/16712 and I don't actually use Go modules under GitLab subgroup.

Reproduction repository: https://github.com/at-wat/renovate-16712/pulls PRs with [local no-GOPROXY] are created by self-hosted Renovate without GOPROXY. Expected: Update module gitlab.com/at-wat-group/subgroup/renovate-test/submodule to v1.0.3 is created Actual: not created

As in the attached log, Renovate tries to git ls-remote https://gitlab.com/at-wat-group/subgroup/renovate-test/submodule.

https://gitlab.com/at-wat-group/subgroup/renovate-test/submodule?go-get=1 returns

<html><head>
<meta name="go-import" content="gitlab.com/at-wat-group/subgroup/renovate-test git https://gitlab.com/at-wat-group/subgroup/renovate-test.git" />
<meta name="go-source" content="gitlab.com/at-wat-group/subgroup/renovate-test https://gitlab.com/at-wat-group/subgroup/renovate-test https://gitlab.com/at-wat-group/subgroup/renovate-test/-/tree/main{/dir} https://gitlab.com/at-wat-group/subgroup/renovate-test/-/blob/main{/dir}/{file}#L{line}" />
</head><body>
go get https://gitlab.com/at-wat-group/subgroup/renovate-test
</body></html>

which says the client should fetch https://gitlab.com/at-wat-group/subgroup/renovate-test for this module.

Relevant debug logs

DEBUG: Datasource unknown error (repository=at-wat/renovate-16712)
       "datasource": "go",
       "packageName": "gitlab.com/at-wat-group/subgroup/renovate-test/submodule",
       "err": {
         "task": {
           "commands": [
             "ls-remote",
             "https://**redacted**@gitlab.com/at-wat-group/subgroup/renovate-test/submodule",
             "refs/tags/v*"
           ],
           "format": "utf-8",
           "parser": "[function]"
         },
         "message": "remote: The project you were looking for could not be found or you don't have permission to view it.\nfatal: repository 'https://gitlab.com/at-wat-group/subgroup/renovate-test/submodule/' not found\n",
         "stack": "Error: remote: The project you were looking for could not be found or you don't have permission to view it.\nfatal: repository 'https://gitlab.com/at-wat-group/subgroup/renovate-test/submodule/' not found\n\n    at Object.action (/home/at-wat/Projects/renovate/node_modules/simple-git/src/lib/plugins/error-detection.plugin.ts:38:28)\n    at PluginStore.exec (/home/at-wat/Projects/renovate/node_modules/simple-git/src/lib/plugins/plugin-store.ts:24:29)\n    at /home/at-wat/Projects/renovate/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:114:40\n    at new Promise (<anonymous>)\n    at GitExecutorChain.handleTaskData (/home/at-wat/Projects/renovate/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:111:14)\n    at GitExecutorChain.<anonymous> (/home/at-wat/Projects/renovate/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:88:40)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/at-wat/Projects/renovate/node_modules/simple-git/dist/cjs/index.js:55:24)\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)"
       }

Have you created a minimal reproduction repository?

I have linked to a minimal reproduction repository in the bug description

Contributor guide

Tech stack: typescriptgo
Domain: backendtooling
Issue type: bug
Difficulty: 3
Estimated time: 1-3 hours
Activity status: active
Clarity: mostly clear
Prerequisites: understanding of Go modulesfamiliarity with Renovate's datasource architecture
Newbie friendliness: 35
Research direction: The issue reveals that when GOPROXY is not set, Renovate attempts to git ls remote directly on the Go module path (e.g., gitlab.com/at wat group/subgroup/renovate test/submodule), but the go get=1 response at that path redirects to the parent repository. Investigate the Go datasource in the Renovate codebase, particularly how it constructs repository URLs for GitLab subgroups. Look at the code related to go datasource and module path resolution, and consider how to properly follow go import meta tags when GOPROXY is not set. The reproduction repository and PR #16712 provide context.