renovatebot/renovate

Bad link escaping on a Medium post

Open

#15958 opened on Jun 9, 2022

View on GitHub
 (9 comments) (0 reactions) (0 assignees)TypeScript (14,066 stars) (1,916 forks)batch import
core:changelogshelp wantedpriority-4-low

Description

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

Fastify release 4.0.0: https://github.com/fastify/fastify/releases/tag/v4.0.0

PR updating it: https://github.com/renovate-reproductions/fastify-4/pull/2

Original text: We are finally shipping Fastify v4, you can read more about it at https://medium.com/@fastifyjs/fastify-v4-ga-59f2103b5f0e

Broken link: We are finally shipping Fastify v4, you can read more about it at https://medium.com/[@​fastifyjs/fastify-v4-ga-59f2103b5f0e](https://togithub.com/fastifyjs/fastify-v4-ga-59f2103b5f0e)

We need to work out why it's being transformed like this.

@waghanza I think this is the problem you intended to alert me to? I didn't see any changelogs in your PR so didn't notice this at first.

Relevant debug logs

Copy/paste the relevant log(s) here, between the starting and ending backticks

Have you created a minimal reproduction repository?

I have linked to a minimal reproduction repository in the bug description

Contributor guide

Tech stack
typescriptnodejs
Domain
backendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptRegular expressionsRenovate codebase awareness
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate how Renovate processes release notes and escapes URLs. The bug report shows that a Medium link is being incorrectly transformed. Look at the code responsible for parsing changelogs, likely in the release notes or repository worker modules. Check the reproduction PR at https://github.com/renovate reproductions/fastify 4/pull/2 for a concrete example. The maintainer suspects this is related to the issue reported by @waghanza, so review related comments and linked issues.