renovatebot/renovate

Implement the explicit `automergeStrategy` for the Bitbucket Server platform.

Open

#10867 opened on Jul 15, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (14,066 stars) (1,916 forks)batch import
core:automergehelp wantedplatform:bitbucket-serverpriority-4-low

Description

What would you like Renovate to be able to do?

The automergeStrategy configuration item introduced in #10627 should be implemented for the Bitbucket Server platform, allowing users to configure the explicit merge strategy used by Renovate when automerging pull requests

Did you already have any implementation ideas?

The optional MergeStrategy argument can be provided to the Bitbucket Server mergePr implementation. If provided, the Renovate-specific strings for automergeStrategy can be mapped to Bitbucket Server-specific strings when submitting the merge request to Bitbucket Server. This can be provided as the strategyId to the POST request to .../pull-requests/${prNo}/merge. Not providing this field (as is the case now) will result in using the repository-defined merge strategy.

If #10830 has been implemented, the arguments to mergePr may be different than what has been listed here. We should also remember to clean up the missing feature notice in lib/platform/bitbucket-server/index.md and update the description in docs/usage/configuration-options.md if necessary.

Contributor guide

Tech stack
typescriptnodejsrest api
Domain
backendapidevops
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptREST APIRenovate platform abstraction
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine existing mergePr implementations for other platforms (e.g., GitHub, GitLab) to understand the MergeStrategy argument pattern. Modify the Bitbucket Server mergePr in lib/platform/bitbucket server/index.ts to map Renovate's automergeStrategy strings to Bitbucket Server strategyId values. The POST request to .../pull requests/${prNo}/merge should include the strategyId when provided. After implementation, update the missing feature notice in the Bitbucket Server platform documentation and the configuration options docs.