remixz/publish-release

Cope better with `EDITOR` not being defined

Open

#6 opened on Aug 17, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (17 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (72 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There are a couple of ways this could be achieved:

  1. Fail-fast with a nice error message if EDITOR has not been defined.
  2. Ask the developer to enter the path to their editor in lieu of EDITOR not being defined.

Ideally, my preference would be for option 2, as I plan to use publish-release within the postpublish hook of all our modules, and this would allow developers who run npm publish to still have things work, rather than requiring them to define EDITOR, then re-run npm run postpublish.

Contributor guide

Research direction
Examine how EDITOR is used in the codebase and decide on the preferred fallback method (error message or interactive prompt).
Tech stack
javascript
Domain
clideveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80