reflux/refluxjs

Reflux stores don't play nice with webpack Hot Module Replacement

Open

#385 opened on Jul 31, 2015

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (5,377 stars) (354 forks)batch import
enhancementhelp wanted

Description

If have simple application using Reflux and everything works properly. I'm using webpack to build and run everything with HMR support. The react components get hot swapped properly and also the Actions and Stores get hot swapped. The only problem is the 'old' Store is still active and still reacting to the Actions. So every compile that changes something in a Store, you end up with another version of the Store.

Is there something that can be done to fix this?

Contributor guide

Tech stack
javascriptreact
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Reflux store lifecyclewebpack HMRJavaScript closures
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate how Reflux stores register with actions. Likely a cleanup mechanism is missing on module replacement. Look at Reflux's Store.js to see how listeners are attached and consider using webpack's module.hot.dispose to detach old stores. Review existing comments for any suggested approaches.