`reflex cloud apps delete <unknown id>` exits 0
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Look at the reflex-hosting-cli package, specifically the command for reflex cloud apps delete. The issue shows the command exits with code 0 when given a non-existent app ID, but should exit 1. Compare the implementation for the ID-based delete with the --app-name delete and the inspect command to see how they handle not-found errors. The fix is likely in the function that processes the delete command, ensuring it returns a non-zero exit code when the app is not found. Run the existing tests for the CLI to verify the behavior.
Written by the indexing model from the issue text.
Description
Package: reflex-hosting-cli (reproduced on main at ea035ea47 and on #7207 at 988718e78)
Deleting an app ID that does not exist prints a warning and exits 0:
$ reflex cloud apps delete 00000000-0000-0000-0000-000000000000 --no-interactive
Warning: No application found with ID '00000000-0000-0000-0000-000000000000'
[exit=0]
The same lookup failure exits 1 elsewhere:
$ reflex cloud apps delete --app-name no-such-app-xyz --no-interactive
Warning: App 'no-such-app-xyz' not found.
[exit=1]
$ reflex cloud apps inspect 00000000-0000-0000-0000-000000000000 --no-interactive
no app with given id found
[exit=1]
A script that runs apps delete $ID && echo deleted reports success when the ID is wrong (typo, wrong account or project).
Expected: an error, and a non-zero exit, when the app ID is not found. This matches --app-name and the other apps subcommands.
- Dominant language
- Python
- Stars
- 28.9k
- Forks
- 1.8k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 180
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from reflex-dev/reflex
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
reflex-dev/reflex#7300 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
reflex-dev/reflex#7298 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
reflex-dev/reflex#7297 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
reflex-dev/reflex#7296 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
reflex-dev/reflex#7294 · 1 comment ·
All issues in reflex-dev/reflex
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
stephrobert/dsoxlab#238 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
sublimehq/package_control#1780 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
nwg-piotr/nwg-displays#145 ·