refinedmods/refinedstorage2

Improve fluid & other resource types disk capacity display in Disk Drive

Open

#370 opened on Apr 27, 2023

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Java (47 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (275 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug

The fluid disk shows as blocks in the disk drive. Ex: picture, the 256B disk shows as 256.000 blocks/items.

2023-04-27_16 16 44 2023-04-27_16 16 47 2023-04-27_16 16 50

(Minor issue yes, just wanted to point it out incase it wasn't known! :D)

How can we reproduce this bug or crash?

Simply by putting a fluid disk into a disk drive

What Minecraft version is this happening on?

Minecraft 1.19.3

What Forge or Fabric version is this happening on?

44.1.0

What Refined Storage version is this happening on?

"2.0.0-milestone.2.8"

Relevant log output

No response

Contributor guide

Research direction
Look at the code that renders the disk drive GUI and identify where the fluid capacity is converted to display value. Ensure fluid units are properly formatted instead of showing as block count.
Tech stack
java
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75