redux-utilities/redux-actions

Should print warning message if type is undefined

Open

#86 opened on May 6, 2016

View on GitHub
 (7 comments) (1 reaction) (1 assignee)JavaScript (340 forks)batch import
help wanted

Repository metrics

Stars
 (6,540 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Consider this code, it's commonly used in my project:

import * as actionTypes from './actionTypes.js'
export default handleActions({
  [actionTypes.ACT_1]: (state, action) => {},
  [actionTypes.ACT_2]: (state, action) => {},
})

If there's a typo in actionTypes variable(ACE_1 for instance), there's no warning, linters can't tell the error too. But it's easy to print warning message using redux-actions.

I'd like to send a PR if it's okay to you.

Contributor guide

Research direction
Add a warning message when an action type evaluates to undefined, typically due to a typo in the action type import. Check the switch statement or handleActions implementation to detect undefined types and console.warn.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptRedux
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85