redux-utilities/redux-actions

Should print warning message if type is undefined

Open

#86 opened on May 6, 2016

View on GitHub
 (7 comments) (1 reaction) (1 assignee)JavaScript (6,540 stars) (340 forks)batch import
help wanted

Description

Consider this code, it's commonly used in my project:

import * as actionTypes from './actionTypes.js'
export default handleActions({
  [actionTypes.ACT_1]: (state, action) => {},
  [actionTypes.ACT_2]: (state, action) => {},
})

If there's a typo in actionTypes variable(ACE_1 for instance), there's no warning, linters can't tell the error too. But it's easy to print warning message using redux-actions.

I'd like to send a PR if it's okay to you.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptRedux conceptsredux actions library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue requests adding a warning when an action type is undefined. Likely the change should be made in the handleActions function, which processes the action map. Check the source code for where types are resolved, and add a console.warn when a type resolves to undefined. No existing PR or assignee activity, so you may start by reviewing the handleActions implementation and proposing a simple warning.