Rule description and descriptionHtml are incorrectly assertNonNull().
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
Research direction
Start at the Rule class constructor and trace the subreddit.getRules() entry point, focusing on the shown assertions for description and descriptionHtml. Reproduce the case with a subreddit rule lacking descriptions and confirm that getRules() succeeds while other required rule fields remain validated.
Written by the indexing model from the issue text.
Description
In old Reddit it is possible to create rules without descriptions. However, the Rule class constructor asserts description and descriptionHtml as non-null. This causes calls to subreddit.getRules() to fail for subreddits with rules lacking descriptions.
assertNonNull(shortName, 'Subreddit rule is missing shortName');
assertNonNull(description, 'Subreddit rule is missing description');
assertNonNull(priority, 'Subreddit rule is missing priority');
assertNonNull(createdUtc, 'Subreddit rule is missing createdUtc');
assertNonNull(descriptionHtml, 'Subreddit rule is missing descriptionHtml');
- Dominant language
- TypeScript
- Stars
- 210
- Forks
- 88
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from reddit/devvit
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 5/5 Over a week Newbie friendliness 42/100
-
Difficulty 5/5 Over a week Newbie friendliness 28/100
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100