recommenders-team/recommenders

[ASK] Confusion between top_k and by_threshold relevancy_method in python_evaluation.py

Open

#2,140 opened on Aug 10, 2024

 (2 comments) (0 reactions) (0 assignees)Python (3,319 forks)batch import
help wanted

Repository metrics

Stars
 (21,866 stars)
PR merge metrics
 (PR metrics pending)

Description

Description

What is the different between k and threshold value here if they all get assigned to top_k? Isn't threshold supposed to be a rating value that the predictions should exceed instead of being the number of items in the top_k list ? Thanks.

def merge_ranking_true_pred(
    rating_true,
    rating_pred,
    col_user,
    col_item,
    col_prediction,
    relevancy_method,
    k=DEFAULT_K,
    threshold=DEFAULT_THRESHOLD,
    **_,
):
    if relevancy_method == "top_k":
        top_k = k
    elif relevancy_method == "by_threshold":
        top_k = threshold

Other Comments

Contributor guide