recommenders-team/recommenders

[ASK] negative_feedback_sampler super slow

Open

#1,539 opened on Sep 26, 2021

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)Python (3,319 forks)batch import
help wanted

Repository metrics

Stars
 (21,866 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi, I got some questions about the usage of negative_feedback_sampler, my codes are as below:

from recommenders.datasets.pandas_df_utils import negative_feedback_sampler

df_feature = negative_feedback_sampler(df_feature_ori,col_user='userid',col_item='sku',col_label='label',ratio_neg_per_user=1)

df_feature_ori has about 623k rows, and 24 columns, but it really takes so long to process the negative_feedback_sampler, I wonder if I do it wrong or it's just normal situation. Any advice would be appreciated.

Contributor guide

Research direction
Profile the negative feedback sampler function using Python's cProfile or time to identify bottlenecks. Check the existing implementation in the repository's datasets/pandas df utils.py.
Tech stack
pythonpandas
Domain
datamachine learning
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70