recloudstream/cloudstream

Improve delayed updater triggering method

Open

#1,282 opened on Aug 16, 2024

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Kotlin (9,642 stars) (877 forks)batch import
enhancementgood first issue

Description

Describe your suggested feature

Currently actually updating is done in onPause() in MainActivity, this causes inconsistent and unexpected triggering behavior. I suggest we move this to onDestroy() And add a persistent notification that says something like "Update now" on mobile, and auto stop app when you click update on TV. This is because onPause() is also triggered when you enter PiP mode or switch activities such as going to "Manage Accounts". I understand the reason for waiting is for user choice but the current implementation I don't think actually indicates "user choice" as if you forget about it or something and go home you inadvertently start the update which force stops the app. To me, this is bad behaviour.

Other details

No response

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Contributor guide

Tech stack
kotlinandroid
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android lifecycleKotlin basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The solution involves moving the update triggering code from onPause() to onDestroy() in MainActivity. A persistent notification with an 'Update now' action should be added. Start by examining the current update logic in MainActivity's onPause() method (likely in the cloudstream Android app). Then migrate that logic to onDestroy() and create a notification using Android's NotificationManager. Ensure that the notification includes a PendingIntent to trigger the update when clicked. Also consider the behavior for PiP (picture in picture) mode to avoid triggering the update inadvertently.