recloudstream/cloudstream

Download does not get removed when cancelling from a notification.

Open

#1,227 opened on Jul 30, 2024

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Kotlin (9,642 stars) (877 forks)batch import
buggood first issue

Description

Steps to reproduce

This was found and explained in https://github.com/recloudstream/cloudstream/pull/1177. The main problem is that the UI is still showing episodes or movies that was deleted by the user if the user cancels an download. This is a preexisting bug, but #1177 made it worse by also affecting episodes instead of just movies.

Expected behavior

The downloadDeleteEvent or similar should be hooked to update the UI in case of deletion from any source.

Actual behavior

Invalid UI

Cloudstream version and commit hash

ab379ab31c30069aac3afdeec76410e69ea6bc95

Android version

N/A

Logcat

No response

Other details

No response

Acknowledgements

  • I am sure my issue is related to the app and NOT some extension.
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to pre-release version Latest.
  • I will fill out all of the requested information in this form.

Contributor guide

Tech stack
kotlinandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic KotlinAndroid developmentevent handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the downloadDeleteEvent mentioned in the issue and PR #1177. Look at the UI update logic after cancellation from notifications. The issue is likely in the download manager or notification handling code. Check the referenced PR for context on how the bug was worsened.