recharts/recharts

payload=[] for Tooltip when allowDuplicatedCategory={false} in XAxis

Open

#2348 opened on Dec 21, 2020

View on GitHub
 (10 comments) (4 reactions) (0 assignees)TypeScript (21,783 stars) (1,637 forks)batch import
buggood first issue

Description

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

In demo link just hovering over a bar and open console. The Tooltip don't show and payload = [].

If just change this line: <XAxis dataKey="name" allowDuplicatedCategory={false} />

for this one

<XAxis dataKey="name" allowDuplicatedCategory={true} />

The Tooltip show and payload = [{ color: "#ff7300", dataKey: "count", fill: "#ff7300", formatter: undefined, name: "count", payload: { count: 32, sum: [12, 16] }, type: undefined, unit: undefined, value: 32 }].

What is expected?

The Tooltip should be displayed when hovering over a bar and payload have array with data. http://prntscr.com/w70392

What is actually happening?

Adding allowDuplicatedCategory={false} to XAxis component in BarChart makes the Tooltip stop working. The Tooltip just don't show when hovering over a bar and payload = []; http://prntscr.com/w6zywz

Environment Info
Recharts v1.8.5
React 16.13.1
System Windows 10 Home 2004
Browser Google Chrome (87.0.4280.88)

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React knowledgeRecharts basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how allowDuplicatedCategory prop affects data passing to Tooltip in Recharts. Focus on XAxis and Tooltip components, likely in src/cartesian/XAxis.tsx and src/component/Tooltip.tsx. The bug seems to cause empty payload when duplicated categories are not allowed. Check how the unique keys are generated and if Tooltip data mapping relies on those keys. Look at existing tests or comments in issue for hints.