realpython/dockerizing-django

misuse of .env file

Open

#36 opened on Sep 20, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (493 forks)batch import
hacktoberfest

Repository metrics

Stars
 (1,326 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The .env file at the root of the repo has special use: https://docs.docker.com/compose/env-file/

The file is sourced when docker-compose is invoked, and the values affect docker-compose commands.

My suggestion is to move the contents of the current .env file to docker-compose*.yml, under a new environment: heading.

For reference: https://docs.docker.com/compose/compose-file/#/environment

Contributor guide

Research direction
Move the environment variables from .env file to the `environment:` key in docker compose.yml files, and remove or ignore the .env file.
Tech stack
pythondocker
Domain
backenddevopsinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
DockerDocker ComposeGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90