realm/SwiftLint

Spaces in function arguments

Open

#5,224 opened on Sep 15, 2023

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Swift (19,570 stars) (2,295 forks)batch import
good first issuerule-request

Description

I would like to remove spaces before the first function argument and after the last function argument. The rule must be opt-in. Need good style code

Bad

makeGenerator(❗️ style ❗️)
makeGenerator(❗️ style)
makeGenerator(style ❗️)
makeGenerator(❗️ offset: 0, limit: 0)
makeGenerator(offset: 0, limit: 0 ❗️)

Good

makeGenerator(style)
makeGenerator(style)
makeGenerator(style)
makeGenerator(offset: 0, limit: 0)
makeGenerator(offset: 0, limit: 0)

Contributor guide

Tech stack
swift
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SwiftSwiftLint rule development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
This issue proposes a new opt in rule to remove spaces around function arguments. To implement, look at existing rule implementations in SwiftLint, such as the `empty parentheses with trailing closure` rule, to understand the structure. The rule should use the SwiftSyntax or SourceKit AST to detect spaces before the first and after the last argument. The issue provides clear examples of bad and good style. Consider adding configuration options for user preference.
Spaces in function arguments · realm/SwiftLint#5224 | Good First Issue