reagent-project/reagent-forms

Update form when atom is replaced?

Open

#107 opened on Jun 14, 2016

View on GitHub
 (7 comments) (0 reactions) (0 assignees)HTML (78 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (337 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I believe I'm hitting similar behavior to a few of the other issues, but it's quite unclear how to resolve.

I have a form as so:

(defn some-form [foo] 
   (let [doc (r/atom {:bar (:bar foo)])
     (fn []
         [bind-fields some-form-template doc])))

The issue is, when some-form is re-rendered (because a level above it is reacting to @\foo), the form does not seem to re-render. (If I throw in a some text field reacting to @\doc here, the text field will update)

What is the proper way to handle this? It's not quite that I am updating the atom externally, it's that I'm asynchronously loading the data that goes into the atom. I want to replace it entirely.

Contributor guide

Research direction
The issue involves a form not re rendering when its underlying atom is replaced. To resolve, first understand how Reagent's reactivity works with atoms and the bind fields function in reagent forms. Review the source code of bind fields and the form template to identify if the atom's replacement triggers re rendering. Check comments in the issue for any suggested approaches or workarounds. Consider whether using reset! on the existing atom instead of creating a new one would solve the problem.
Tech stack
None
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ClojureScriptReagentreagent forms library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20