readthedocs/sphinx_rtd_theme

Reduce bottom-margin for code blocks within lists

Open

#706 opened on Dec 17, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)CSS (3,473 stars) (1,413 forks)batch import
BugGood First Issue

Description

Problem

Like for <p>, also 50% bottom margin for code blocks within lists:

image

Margin after <p>Code sample:</p> there is 12px, but margin after code block is 24px.

Other

I don't think there's need to support case with bottom margin of 0 because code blocks probably always exist within "open" lists - never in compact lists (would be weird).

Also check if there are any other elements that should be tuned for half the margin when they exist within lists (e.g. tables)?

Environment Info

  • Python Version: 2.7
  • Sphinx Version: 1.8.2
  • RTD Theme Version: 0.4.2

Contributor guide

Tech stack
css
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic CSS knowledgeaccess to Sphinx theme development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate the CSS rule that sets margin bottom for code blocks within lists. The issue suggests reducing it from 24px to 12px. Also inspect any other elements like tables that might need similar adjustment. The fix is likely in a .rst or .css file in the theme's static directory.