reactjs/react-modal

Focus escapes modal when radio buttons in modal

Open

#636 opened on Mar 29, 2018

View on GitHub
 (8 comments) (11 reactions) (0 assignees)JavaScript (7,294 stars) (828 forks)batch import
accessibilitybugeasygood first issue

Description

Summary:

When there are radio buttons in a modal, you can escape focus with shift-tab.

Steps to reproduce:

Steps are included in the test case below

Expected behavior:

You should not be able to escape the modal's focus

Link to example of issue:

https://codesandbox.io/s/my9vm34m68

Additional notes:

Not sure if it's related specifically to radio buttons, but that is what is causing the issue for me

Contributor guide

Tech stack
reactjavascript
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React basicsFocus management in web appsUnderstanding of tab order
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the focus trapping logic in the modal component, likely in files like 'src/components/Modal.js' or similar. The provided CodeSandbox (https://codesandbox.io/s/my9vm34m68) demonstrates the issue with Shift+Tab escaping when radio buttons are present. Review the focus management code, particularly how it handles the first and last focusable elements, and ensure radio buttons are properly included in the focus order. Consider using a focus trap library like 'focus trap' or adjusting the existing implementation to handle the radio button's group focus behavior.