reactjs/react-modal

Moving to a "modern" build system (hardcore level)

Open

#1036 opened on Feb 8, 2024

View on GitHub
 (6 comments) (1 reaction) (0 assignees)JavaScript (7,294 stars) (828 forks)batch import
buildhelp wanted

Description

react-modal uses an old toolchain system for build and testing (not that the tools aren't great, but because javascript toolchain are pretty messy and not reliable as things changes all the time).

The idea is to move to a "modern" build system (probably vite as it also has compatibility with karma, but suggestions are welcome) as people apparently have move to it.

Contributor guide

Tech stack
javascriptreactvite
Domain
build systemdeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of current build toolchain (webpack, karma)Familiarity with Vite or modern bundlersKnowledge of React component build process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Review the current build configuration in the repository, including webpack and karma setup. Examine the comments in the issue for any suggested approaches or concerns. Prototype migration to Vite, ensuring compatibility with existing tests (karma). Discuss with maintainers on the preferred migration path.