reactjs/react-modal

Replace focus trap with `inert`

Open

#1011 opened on Mar 29, 2023

View on GitHub
 (1 comment) (4 reactions) (0 assignees)JavaScript (7,294 stars) (828 forks)batch import
accessibilitybrowser apicombining librariesdependenciesdiscussioneasyfeaturegood first issue

Description

Now that browsers have good support for inert, could we consider replacing the custom focus trap logic with this?

Alternatively, we could use the dialog element so we get this behaviour for free.

Contributor guide

Tech stack
reactjavascript
Domain
accessibilityfrontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React component structurefocus trap conceptHTML inert attribute
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the current focus trap implementation in react modal (likely in src/modal.js or similar). Determine whether the `inert` attribute can be applied to the modal's backdrop or content. Consider the two approaches: adding `inert` to siblings or using the native `<dialog>` element. Check browser support and fallback for older browsers. Review the existing comment for maintainer feedback.