Crash with Flow component syntax

Open
#944 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, react
Domain
tooling

Research direction

Reproduce the Flow component example from the issue in playground.tsx and confirm the reported syntax error. Trace the parser handling for this component syntax; done means the example parses and produces the expected component metadata. No implementation file or test is named, so finding the relevant parser entry point is part of the work.

Written by the indexing model from the issue text.

Description

flow

Docs: https://flow.org/en/docs/react/component-syntax/

Code
component Example( text: string = 'Hello World' ) {
    return <div>{text}</div>;
}
Expected
[
  {
    "description": "",
    "displayName": "Example",
    "methods": [],
    "props": {
      "text": {
        "required": false,
        "flowType": {
          "text": "string"
        },
        "description": "",
        "defaultValue": {
          "value": "'Hello World'",
          "computed": false
        }
      }
    }
  }
]
Actual
SyntaxError: playground.tsx: Missing semicolon. (1:9)

> 1 | component Example(
    |          ^
  2 | 	text: string = 'Hello World'
  3 | ) {
  4 | 	return <div>{text}</div>
Dominant language
TypeScript
Stars
3.8k
Forks
316
Avg merge
3h 28m
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from reactjs/react-docgen

All issues in reactjs/react-docgen

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.