CSS Modules
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
Research direction
No files, tests, or entry points are named. Start by reviewing the proposed cssselect, VDOM selector-engine, and JavaScript approaches, along with the related issue #194. The issue needs a chosen design and acceptance criteria before “done” can be evaluated.
Written by the indexing model from the issue text.
Description
Current Situation
There is built-in method of directly tying a CSS file to a component
Proposed Actions
Design Idea: Apply in-line styles via Python cssselect
We could parse the CSS document using lxml.cssselect and potentially add the styles in-line. This might need us to generate some sort of VDOM-LXML compatibility layer though. Might be difficult to do this in a performant manner, but it would be the easiest way for us to not ever "fall out of date" with new CSS selectors.
Design Idea: Apply in-line styles via Python homebrewed VDOM selector engine
It might be make sense (from a performance standpoint) to homebrew a VDOM-compatible CSS selection engine... There are a couple we can take inspiration from: vtree-select, cssauron. This would be a pretty large undertaking, and gets really tricky with all of the CSS level 3 selectors.
Design Idea: Leverage django_css
django_cssAdd a css_module decorator that loads a stylesheet using django_css(..., only_once=True) (see here: #194).
By default, it will attempt to load the Django static file named <REACTPY_STYLESHEET_SUBDIR>/<COMPONENT_DOTTED_PATH>.css. But the user will be able to override the path using positional args.
Will need a settings.py configuration setting called REACTPY_STYLESHEET_SUBDIR. Additionally, it makes sense for a manual override to exist within the decorator css_module(subdir="...") for library maintainers to use.
This doesn't really "tie" a piece of CSS to a component. It only ties the load time together.
Design Idea: Apply in-line styles via JavaScript (client sided)
It's also possible for us to instead apply the inline styles client-sided, via some kind of JavaScript. There appears to be a package that does this.
This would be pretty janky in terms of loading behavior.
- Dominant language
- Python
- Stars
- 357
- Forks
- 22
- Avg merge
- 10h 31m
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from reactive-python/reactpy-django
-
Add coverage tests Opencomplexity: 3 (low) priority: 3 (low) type: ci
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
complexity: 1 (high) priority: 1 (high)
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
complexity: 2 (medium) priority: 3 (low)
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
complexity: 2 (medium) priority: 3 (low)
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
complexity: 1 (high) priority: 2 (moderate)
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in reactive-python/reactpy-django
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100