reactioncommerce/reaction

Wrong scale for RUB currency

Open

#6,519 opened on Oct 27, 2017

View on GitHub
 (8 comments) (2 reactions) (0 assignees)JavaScript (2,198 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (12,181 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Prices in Russian rubles appears 100 times as much as their correct values. For example, a price "$12.99 - $29.99" shows up in rubles like "75490 - 1 74284 руб." Correct values should be "754,90 - 1 742,84 руб."

Reproduces on the main page and the product details pages.

Fixed this in local database by removing "scale: 0" property from meteor.Shops.currencies.RUB with query: db.Shops.updateMany({}, {$unset: {"currencies.RUB.scale": ""}})

Versions: Node: 6.11.0 NPM: 3.10.10 Meteor Node: 4.8.4 Meteor NPM: 4.6.1 Reaction CLI: 0.19.0 Reaction: 1.5.4 Reaction branch: master

Contributor guide

Research direction
Investigate the currency scale property in the Shops collection, specifically the 'currencies.RUB.scale' field. Check if it is incorrectly set to '0', and ensure the correct scaling for Russian rubles (2 decimal places). The issue can be reproduced by observing prices on the main page or product details. The fix involves removing the scale property from that currency document, as shown in the issue description.
Tech stack
javascriptnodejsreactgraphql
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
MongoDBMeteor
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70