reactioncommerce/reaction

Wrong scale for RUB currency

Open

#6519 opened on Oct 27, 2017

View on GitHub
 (8 comments) (2 reactions) (0 assignees)JavaScript (12,181 stars) (2,198 forks)batch import
buggood first issuehelp wanted

Description

Prices in Russian rubles appears 100 times as much as their correct values. For example, a price "$12.99 - $29.99" shows up in rubles like "75490 - 1 74284 руб." Correct values should be "754,90 - 1 742,84 руб."

Reproduces on the main page and the product details pages.

Fixed this in local database by removing "scale: 0" property from meteor.Shops.currencies.RUB with query: db.Shops.updateMany({}, {$unset: {"currencies.RUB.scale": ""}})

Versions: Node: 6.11.0 NPM: 3.10.10 Meteor Node: 4.8.4 Meteor NPM: 4.6.1 Reaction CLI: 0.19.0 Reaction: 1.5.4 Reaction branch: master

Contributor guide

Tech stack
javascriptnodejsmongodb
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
MongoDB basicsMeteor collection structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue involves a bug where Russian ruble prices are 100x too high due to a 'scale: 0' property in the currencies.RUB field of the Shops collection. The user provided a fix by removing that property via a MongoDB update. To resolve, verify the current state of the Shops collection schema and decide whether to remove the 'scale' property or adjust the scaling logic. Check if any related changes have been made in the codebase since 2017. The fix is localized to the MongoDB document.