reactioncommerce/reaction

`getPaginatedResponseFromAggregate` throws error when query includes `hasNextPage` and `totalCount`

Open

#6509 opened on Sep 16, 2021

View on GitHub
 (1 comment) (4 reactions) (0 assignees)JavaScript (12,181 stars) (2,198 forks)batch import
bughelp wanted

Description

When a plugin uses this method to format the response of a query, and the request includes either hasNextPage or totalCount property, the API throws error.

In the case of hasNextPage the errors is the following:

"count can only be used with find command"

An example query that causes this error is:

query {
  vendors(shopIds: []) {
    nodes {
    name
    }
    pageInfo {
      hasNextPage
    }
  }
}

In the case of totalCount the error is:

"Invalid $addFields :: caused by :: FieldPath field names may not start with '$'."

An example query that causes this error is:

query {
  vendors(shopIds: []) {
    nodes {
    name
    }
    totalCount
  }
}

Contributor guide

Tech stack
javascriptnodejsgraphql
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GraphQLMongoDB aggregationNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the getPaginatedResponseFromAggregate helper function in the GraphQL schema or resolver. The error 'count can only be used with find command' suggests that the aggregation pipeline is incorrectly using the $count stage after a $facet or similar. The second error about $addFields indicates a field path issue with dollar sign. Look at the implementation, possibly in packages/api core or similar, and ensure that pagination metadata fields are computed correctly without conflicting with aggregation stages. Consider using $facet for separate count queries. Also check if the issue is related to the GraphQL resolvers that call this helper.