reactioncommerce/reaction

Add offset pagination everywhere

Open

#6252 opened on May 22, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (12,181 stars) (2,198 forks)batch import
enhancementhelp wanted

Description

The pagination util function supports offset automatically, but the offset field needs to be added to the GraphQL schema params for each query for it to work. This is a general tracking issue, but someone should investigate to determine which queries and missing offset, and create an individual enhancement issue for each in the api-plugin-* repos.

Contributor guide

Tech stack
javascriptgraphqlnodejsreact
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
GraphQL schema knowledgeUnderstanding of offset paginationFamiliarity with Reaction Commerce plugin structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the pagination utility function in the codebase to understand how offset is supported. Then, examine each GraphQL query schema in the api plugin * repositories to identify which queries are missing the offset parameter. Create individual enhancement issues for each missing offset, referencing the original tracking issue #6252.