[Chore] Simplify the generation of the type definition files
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- build-system, tooling
Research direction
First check whether the referenced flow-bundler has been migrated to the hermes repo and released as a standalone package. Then compare its possible use with the current flow-api-translator, concatenation script, and folder-deletion build steps. Done means the generated Flow and TypeScript definitions remain correct without the brittle concatenation process.
Written by the indexing model from the issue text.
Description
React Strict DOM has a single file for Flow type definitions and a single file for TS type definitions.
The build step for this is fairly complex, however:
- We transform the entire folder of source files to individual
.js.flowand.d.tsfiles usingflow-api-translator. - We then use a script to concatenate all the type files into a single file
- We then delete the folder
The script that concatenates the types from all the files is brittle and can break if we accidentally use the same type name in different files.
We should be able to simplify this process by using this Rollup-like bundler that understands Flow syntax.
We will need to wait for this bundler to be migrated to the hermes repo and open-sourced as a standalone package.
- Dominant language
- JavaScript
- Stars
- 3.6k
- Forks
- 206
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from react/react-strict-dom
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
react/react-strict-dom#467 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
react/react-strict-dom#465 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
react/react-strict-dom#520 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
react/react-strict-dom#505 · 2 reactions ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 62/100
react/react-strict-dom#491 · 4 comments ·
All issues in react/react-strict-dom
Similar issues
-
awaiting triage bug Causes friction Hop Gui P1 P2 Transforms
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
georgestephanis/p2026#40 ·
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Margaret-Petersen/food-delivery-app-clone-react-native#1981 ·