Keyboard.addListener ignores its context argument

Open Beginner friendly
#58,230 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript, react-native
Domain
mobile

Research direction

Start at the public Keyboard.addListener(eventType, listener, context?) entry point and trace how it forwards arguments to NativeEventEmitter. Verify that callbacks supplied with a context execute with that object as this, while existing behavior remains unchanged when no context is provided.

Written by the indexing model from the issue text.

Description

Needs: Author Feedback Needs: Repro
Description

The public Keyboard.addListener(eventType, listener, context?) signature accepts a listener context, but the implementation forwards only the event type and callback to NativeEventEmitter. The supplied context is therefore silently discarded.

Expected behavior

When a context is supplied, keyboard event callbacks should run with that object as this, matching the underlying NativeEventEmitter contract.

React Native Version

0.87.1 and current main

Affected Platforms

JavaScript runtime - All

Dominant language
C++
Stars
127k
Forks
25.3k
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from react/react-native

All issues in react/react-native

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.