react-toolbox/react-toolbox

Allow setting id

Open

#1351 opened on Mar 24, 2017

View on GitHub
 (4 comments) (2 reactions) (0 assignees)JavaScript (8,676 stars) (1,036 forks)batch import
Type: Enhancementgood first issue

Description

Most components allow you to specify a class: http://react-toolbox.com/#/components/tabs

Can you please also allow specifying an id?

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with React componentsBasic understanding of React props
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Look at existing React components in the repository, such as Tabs or others that already support a 'className' prop. Identify the pattern used to pass the className prop to the rendered DOM element. Then implement a similar pattern for an 'id' prop. Check the source files in the 'components' directory (e.g., src/components/Tabs) to see the current implementation. Also review any existing discussion in the issue comments for additional context or constraints.