Add enable props

Open

#61 opened on Oct 10, 2020 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 35/100

Issue type: Feature
Clarity: Mostly clear
Activity status: Stale
Tech stack: react, typescript
Domain: frontend, tooling

Research direction

Start at the entry point and inspect how NODE_ENV currently controls whether the UI is included. Trace the development and production package entry paths, then define the enable prop behavior and verify that the requested production-build usage works without requiring the development import path.

Written by the indexing model from the issue text.

Description

feature request help wanted

Hi.
I love this devtools. Thanks for all contributors!

Currently, this devtools UI are included application ifNODE_ENV is NOT production.
But, I think people who want to create an application as experimental wants to enable devtools UI in production build.
I'm one of them.
https://sandbox-redux-toolkit-create-entity-adapter.vercel.app/
(In this case, I wroteimport * as ReactHookFormDevTool from '@hookform/devtools/dist/index.cjs.development.js'; https://github.com/tyankatsu0105/sandbox-redux-toolkit-create-entity-adapter/blob/15e845c47090a03e5baf0d4ab8306ae651ea19ce/apps/client/components/create/add-one/add-one.container.tsx#L5)

So, I propose props enable: boolean to <DevTool />
Like this:

import * as ReactHookFormDevTool from "@hookform/devtools/dist/index.cjs.development.js";

export const Component = () => (
  <ReactHookFormDevTool.DevTool control={control} enable />
);
// or
export const Component = () => (
  <ReactHookFormDevTool.DevTool
    control={control}
    enable={NODE_ENV === "production"}
  />
);

Dominant language: TypeScript
Stars: 670
Forks: 55
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.