Missing peerDependency `@types/react`

Open
#743 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript, react
Domain
frontend

Research direction

Inspect package.json around line 99 and compare the dependency metadata with how pnpm resolves @types/react during type checking. Update the peer dependency declaration, then verify that the package metadata provides @types/react to consumers without requiring a .pnpmfile.cjs workaround.

Written by the indexing model from the issue text.

Description

https://github.com/react-grid-layout/react-draggable/blob/2c3aa84352ca8eaed42a9ac0b59a1187e7850b6a/package.json#L99

Under pnpm this package will not have @types/react when type checking is used. It should specify it as a peer dependency as it is assumed to be needed. We needed to use .pnpmfile.cjs to fix this on our end.

Dominant language
JavaScript
Stars
9.3k
Forks
1k
Avg merge
3d 8h
Merged PRs (30d)
4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from react-grid-layout/react-draggable

All issues in react-grid-layout/react-draggable

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.