isVisible failing with element from a different window

Open
#436 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
39/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
react, typescript
Domain
frontend

Research direction

Locate the isVisible function in the react-component/util codebase and inspect its Element instance check. Reproduce the behavior with an element from another window, then verify that the visibility check handles that element correctly using the owner document's window context.

Written by the indexing model from the issue text.

Description

Hey,

I wanted to report a small issue with isVisible function.

I'm working on an application that opens new windows to show some components. We rely on react component for tooltips and popup and we realized that they are failing on those components that run on the new windows. After some investigation we realised that the issue came from the isVisible function that fails when the element comes from another window.

The problem comes from the element instanceof Element that always fails because the `Element' class instance is window dependant.

There is a fix for which is to rely on element.ownerDocument.defaultView.Element instead.

Would accept a PR for this issue?

Best,

Dominant language
TypeScript
Stars
670
Forks
205
Avg merge
15d 17h
Merged PRs (30d)
6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from react-component/util

All issues in react-component/util

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.