duplicate key in tabs overflow menu
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start with src/hooks/useVisibleRange.ts at lines 42-61 and trace how its range is used to build hiddenTabs in TabNavList. Reproduce the overflow case with a custom tab element or CSS that affects measurement, then verify the overflow menu no longer contains duplicate items when startIndex exceeds endIndex.
Written by the indexing model from the issue text.
Description
in this function, sometimes the startIndex is bigger than the endIndex, causing the menu for hiddenTabs in TabNavList to have duplicated items.
I guess some tab extra element with user defined css can cause it to measure things incorrectly.
could we add a simple protection like
if (startIndex > endIndex) {
endIndex = startIndex;
}
- Dominant language
- TypeScript
- Stars
- 572
- Forks
- 241
- Avg merge
- 4d 18h
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from react-component/tabs
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
react-component/tabs#865 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
react-component/tabs#809 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 64/100
react-component/tabs#1013 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
react-component/tabs#777 · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
react-component/tabs#726 ·
All issues in react-component/tabs
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
mksglu/context-mode#1200 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
jaegertracing/jaeger-ui#4506 ·
-
area:desktop area:ui bug platform:macos
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
anthropics/claude-code#96687 ·
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 95/100
AOSSIE-Org/DebateAI#582 · 2 comments ·