react-bootstrap-table/react-bootstrap-table2

Add callback when editing on cell is cancelled

Open

#684 opened on Nov 26, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,249 stars) (415 forks)batch import
cell-editorgood first issuehelp wanted

Description

In version 1.2.2 of react-bootstrap-table2-editor, it is possible to be notified when a cell enters the editing state using onStartEdit. However, if blurToSave is set to false, there is no way to determine that editing was cancelled when the user clicks away from the editing cell and the cell transitions back to a non-editing state. It would be very useful to have a onEditCancel (or some other appropriate name) callback method that could be set for this case. When blurToSave is true, all is fine as any change in focus, leads to the afterCellSave method to be called.

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Reactreact bootstrap table2 basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the current implementation of cell editing in the package, specifically the onStartEdit callback and how the cell transitions between editing and non editing states when blurToSave is false. Look at the source code for the cell editor component to understand where to hook in a new onEditCancel prop. Consider how to differentiate between save and cancel events, and ensure the new callback is only triggered on cancellation. Check existing tests for similar callbacks to follow the pattern.