react-bootstrap-table/react-bootstrap-table2

defaultSorted cannot sort more than one column

Open

#1083 opened on Sep 3, 2019

View on GitHub
 (4 comments) (2 reactions) (1 assignee)JavaScript (1,249 stars) (415 forks)batch import
help wantedsort

Description

Describe the bug Only the first column of the defaultSorted array is considered. I see #717 was closed, but neither the documentation nor the linked example contains two columns in defaultSorted.

codesandbox https://codesandbox.io/embed/react-bootstrap-table-next-basic-example-69nq0

Note that the second sort column is on price descending, so the row with id 2 should be displayed first.

In general, the expected behavior here is that the table is first sorted by name, and then for items with the same name, they should be ordered by price in descending.

Happy to provide more examples as needed.

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJavaScriptreact bootstrap table2 basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
First, reproduce the issue using the provided CodeSandbox (inline note: the second sort column on 'price' descending is not applied). Examine the source code for the `defaultSorted` prop handling, likely in the sorting utility or in the main table component. The referenced issue #717 was closed but may reveal previous attempts. Check if the sorting logic iterates only over the first entry of `defaultSorted` and needs to handle multiple columns by chaining sort comparators. Look at the `src/sorting.js` or similar file for the sort state initialization and applyChanges methods.