reach/router

Active link is not asserted for URL with special characters

Open

#320 opened on Nov 1, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (6,917 stars) (352 forks)batch import
good first issuehelp wanted

Description

I think that here:

https://github.com/reach/router/blob/28a79e7fc3a3487cb3304210dc3501efb8a50eba/src/index.js#L406-L407

location.pathname should be instead decodeURIComponent(location.pathname)

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript fundamentalsURI encoding basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Review the linked code at src/index.js lines 406-407. The issue suggests replacing location.pathname with decodeURIComponent(location.pathname) to handle special characters. Check if there are any other places in the codebase where similar assertions occur. Look at the repository's test files for active link tests to understand the expected behavior.