reach/router

Active link is not asserted for URL with special characters

Open

#320 opened on Nov 1, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (352 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (6,917 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I think that here:

https://github.com/reach/router/blob/28a79e7fc3a3487cb3304210dc3501efb8a50eba/src/index.js#L406-L407

location.pathname should be instead decodeURIComponent(location.pathname)

Contributor guide

Research direction
Look at the linked line in index.js (L406 L407) and replace location.pathname with decodeURIComponent(location.pathname) to properly handle URLs with special characters.
Tech stack
javascriptreact
Domain
frontendweb dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85