rapidsai/cuml

[BUG] `make_regression` is not deterministic with `shuffle=True`.

Open

#7,871 opened on Mar 7, 2026

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Python (644 forks)auto 404
buggood first issue

Repository metrics

Stars
 (5,223 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug As in the title. Running it multiple times with the same seed generates different results.

Steps/Code to reproduce bug

from cuml.datasets import make_regression
import cupy as cp

X1, y1 = make_regression(
    n_samples=100, n_features=5, n_informative=5, random_state=42
)
X2, y2 = make_regression(
    n_samples=100, n_features=5, n_informative=5, random_state=42
)

assert cp.array_equal(X1, X2)
assert cp.array_equal(y1, y2)

Additional context Add any other context about the problem here.

It seems rand() is used by raft: https://github.com/rapidsai/raft/blob/bf258f39b670d65c60d8a681c8ec45d0ade5690f/cpp/include/raft/random/detail/permute.cuh#L126

Contributor guide

Research direction
Examine the random number generation in raft's permute.cuh to ensure deterministic behavior. Verify that the random state is correctly propagated and that shuffle operations are reproducible.
Tech stack
python
Domain
machine learning
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65