Bug in python replication logic?

Open Beginner friendly
#5,630 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
distributed-systems

Research direction

Locate the _mg_call_plc_replicate entry point and inspect the input_type branches shown in the issue. Confirm that dataframe and series inputs dispatch to their intended helpers; the issue names no file or test, so identify the relevant replication test coverage before making the small correction.

Written by the indexing model from the issue text.

Description

def _mg_call_plc_replicate(
    client: dask.distributed.client.Client,
    sID: bytes,
    dask_object: dict,
    input_type: str,
    col_names: list,
) -> Union[dask_cudf.DataFrame, dask_cudf.Series]:
    if input_type == "dataframe":
        result = [
            client.submit(
                _call_plc_replicate_dataframe,
                sID,
                edata,
                workers=[w],
                allow_other_workers=False,
                pure=False,
            )
            for w, edata in dask_object.items()
        ]
    elif input_type == "dataframe":
        result = [
            client.submit(
                _call_plc_replicate_series,
                sID,
                edata,
                workers=[w],
                allow_other_workers=False,
                pure=False,
            )
            for w, edata in dask_object.items()
        ]

Not directly related to this PR, but this code looks suspicious as well.

    elif input_type == "dataframe":

Shouldn't "dataframe" here be "series"?

Originally posted by @seunghwak in https://github.com/rapidsai/cugraph/issues/5628#issuecomment-5299641193

Dominant language
Cuda
Stars
2.2k
Forks
369
Avg merge
2d 14h
Merged PRs (30d)
36

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rapidsai/cugraph

All issues in rapidsai/cugraph

Similar issues

More Distributed Systems issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.