rapidsai/cudf

Add unit tests for fixed point in quantiles

Closed

#9,469 opened on Oct 19, 2021

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)C++ (735 forks)batch import
buggood first issuelibcudftests

Repository metrics

Stars
 (6,000 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug Quantiles support fixed point columns. but it is not tested in unit tests (both gtest and pytest).

Expected behavior add unit tests for fixed_point in quantiles gtest

Additional context https://github.com/rapidsai/cudf/issues/9468 While adding FixedPointTypes to cudf::test::AllTypes, QUANTILES_TEST (Failed).

[ FAILED ] QuantileUnsupportedTypesTest/10.TestZeroElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/10.TestOneElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/10.TestMultipleElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestZeroElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestOneElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestMultipleElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10>

6 FAILED TESTS

Contributor guide

Research direction
Study the existing quantile tests in gtest (e.g., quantile test.cpp) and add test cases for fixed point types using the AllTypes pattern. Follow the pattern of other types.
Tech stack
cpppython
Domain
backenddata
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75