rapidsai/cudf

[FEA] add value methods to fixed_point_scalar_device_view

Open

#8,455 opened on Jun 8, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (735 forks)batch import
feature requestgood first issuelibcudf

Repository metrics

Stars
 (6,000 stars)
PR merge metrics
 (Avg merge 17d 21h) (230 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

libcudf fixed_point_scalar_device_view has set_value(rep_type). It doesn't have T value() and set_value(T). These are needed for usage of fixed_point_scalar_device_view in device code.

Describe the solution you'd like Add T value() and set_value(T) methods.

Additional context This issue was found while developing scalar support for compiled binary ops #8192.

Contributor guide

Research direction
Examine the existing fixed point scalar device view class to understand its current interface, then add T value() and set value(T) methods consistent with the existing set value(rep type). Ensure the new methods operate correctly in device code.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75