rapidsai/cudf

[FEA] Improve readability of thread id based branching

Open

#6,241 opened on Sep 15, 2020

View on GitHub
 (6 comments) (2 reactions) (0 assignees)C++ (735 forks)batch import
cuIOfeature requestgood first issuelibcudf

Repository metrics

Stars
 (6,000 stars)
PR merge metrics
 (Avg merge 17d 21h) (230 merged PRs in 30d)

Description

Improve readability of thread id based branches by giving them more descriptive names.

e.g.

if (!t) // is actually a t == 0

and

https://github.com/rapidsai/cudf/blob/57ef76927373d7260b6a0eda781e59a4c563d36e/cpp/src/io/statistics/column_stats.cu#L285 Is actually a lane_id == 0 As demonstrated in https://github.com/rapidsai/cudf/issues/6241#issuecomment-693125331, prefer cooperative groups for this.

and

https://github.com/rapidsai/cudf/blob/85cd56dfb3449140f18c7cef3a3be01ac976fd14/cpp/src/io/parquet/page_enc.cu#L1256 is actually t < 32 lane_id == 31. (I think this might be an oversight, ignore as it might be fixed in #6238 ).

Contributor guide

Research direction
Replace raw thread ID checks (e.g., `!t`, `lane id == 0`) with descriptive names and use cooperative groups where appropriate for better readability.
Tech stack
cpp
Domain
backenddata
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++CUDA
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40