rapidsai/cudf

[FEA] Clean up `type_to_name` and add `print_type` debug utility

Open

#17,376 opened on Nov 19, 2024

View on GitHub
 (5 comments) (1 reaction) (0 assignees)C++ (735 forks)batch import
feature requestgood first issuelibcudf

Repository metrics

Stars
 (6,000 stars)
PR merge metrics
 (Avg merge 17d 21h) (230 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. PR #17194 introduces a type_id to string utility located within the benchmark code.

@ttnghia identified that this could be a shared utility for both benchmarks and tests, as it could also be used to create a print_type utility for debugging purposes (see: https://github.com/rapidsai/cudf/pull/17194/files#r1849064965). @davidwendt highlighted that this feature is redundant and performs a similar function to type_to_name.

Describe the solution you'd like

  • Once #17194 is merged, replace stringify_type with type_to_name
  • Replace the type stringify logic in benchmarks/io/nvbench_helpers.hpp with type_to_name
  • Add a host-device print_type utility in cudf_test/print_utilities.cuh using type_to_name for debugging (Note that making it host-device is not mandatory, as type_to_name is currently host-only. However, enabling its use on both host and device, as required by print_type, would involve additional work, such as relocating it to a .cuh header and potentially modifying downstream usage.)

Contributor guide

Research direction
Locate `stringify type` in benchmarks code and replace with `type to name` from cudf. Then add host device `print type` utility in `cudf test/print utilities.cuh` using `type to name`. Ensure to handle potential relocation of `type to name` to a .cuh header for device usage.
Tech stack
c
Domain
backenddata
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++CUDA
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30