rapidsai/cudf

Deprecate windowslinetermination from libcudf read_csv

Open

#15,985 opened on Jun 11, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (6,000 stars) (735 forks)batch import
cuIOgood first issuelibcudf

Description

It doesn't do anything (there are only getters and setters for it defined in the csv header file, but it is not used in the csv reader cuda files).

See Github code search link https://github.com/search?q=repo%3Arapidsai%2Fcudf%20windowslinetermination&type=code

Contributor guide

Tech stack
cpp
Domain
data
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
First, examine the provided GitHub code search link to confirm that the parameter 'windowslinetermination' is indeed unused in the CSV reader CUDA files. Then, locate the header file for the CSV reader (likely in cpp/src/io/csv/), find the getter and setter functions for this parameter, and mark them as deprecated using a deprecation attribute or macro. Update any documentation or comments referencing it. Finally, ensure no other part of the codebase relies on this parameter by searching for any remaining references.