rahuldkjain/github-profile-readme-generator

Social button generator adding "/" even when there is no url base.

Open

#287 opened on Oct 21, 2020

View on GitHub
 (4 comments) (0 reactions) (1 assignee)JavaScript (19,657 stars) (5,899 forks)batch import
buggood first issuehacktoberfestv1-deprecated

Description

Describe the bug Whenever a social button is generated it takes the URL base and the username and puts a "/" in between them. This might cause a problem with the RSS URL. Since it takes a whole URL from the user there's no base URL. That causes it to generate with a / in front of the link provided by the user. In this case, the hyperlink is interpreted as a subpage, not an external website.

To Reproduce Steps to reproduce the behavior:

  1. Go to Social section
  2. Enter any link into the RSS field
  3. Generate the markdown
  4. Click the generated button to see the error

Expected behavior This behavior should only be in place for URLs that have a base, otherwise, it should put only the link as the hyperlink.

Screenshots image image image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 86.0.4240.75

Smartphone (please complete the following information):

  • Device: Huawei P10
  • OS: Android 9
  • Browser Chrome
  • Version 86.0.4240.00

Additional context N/A

Join the Discord Server for further discussions. Server Link: https://discord.gg/HHMs7Eg

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptUnderstanding of URL parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Find the function that constructs the social button URL in the JavaScript code. The issue is that a '/' is always prepended even when there is no base URL (like for RSS where a full URL is provided). Modify the logic to only add the '/' when a base URL exists. Check the repository's source code for the social section generation.