Multiple typos and minor inconsistencies across Parts 8-14

Open
#60 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
72/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
documentation

Research direction

Start with the linked course pages for Parts 8.3 through 14.3 and locate their corresponding source content. Apply the listed typo, wording, type-annotation, and output corrections, then review each page to confirm all reported inconsistencies are resolved.

Written by the indexing model from the issue text.

Description

Hi! While going through the Advanced Course in Programming material, I noticed several typos and a few small inconsistencies. I've collected them below by part so they're easier to locate.

Part 8.3 - Defining classes

https://programming-26.mooc.fi/part-8/3-defining-classes

  • objecs -> objects
Part 8.5 - More examples of classes

https://programming-26.mooc.fi/part-8/5-more-examples-of-classes

  • rectanlge -> rectangle
Part 9.6 - More examples with classes

https://programming-26.mooc.fi/part-9/6-more-examples-with-classes

  • Cargo Hold -> CargoHold this refers to the class name, so it should match CargoHold.
Part 10.1 - Class hierarchies

https://programming-26.mooc.fi/part-10/1-class-hierarchies

The Student constructor has this type annotation in two places:

credits: str

It looks like this should be:

credits: int
Part 10.3 - Object oriented programming techniques

https://programming-26.mooc.fi/part-10/3-oo-programming-techniques

There's an inconsistency between the __str__ implementation and the displayed output.

The method is defined as:

def __str__(self):
    return f"{self.__name} (price {self.__price})"

but the displayed output is:

Apple (2.99)
Orange (3.95)

With the given implementation, the output should be:

Apple (price 2.99)
Orange (price 3.95)

(Alternatively, the implementation could be changed if the shorter output is intended.)

Part 10.4 - Application development

https://programming-26.mooc.fi/part-10/4-application-development

  • Fo decades -> For decades
Part 11.3 - Recursion

https://programming-26.mooc.fi/part-11/3-recursion

  • beacuse -> because

Two more sentences that might be worth reviewing for wording (possibly intentional, just flagging):

  • "...which has its own copies of the variables visible." -> maybe "...which has its own copies of the variables shown."
  • "returns with a value - it is 1" -> maybe "returns a value, in this case, 1."
Part 12.3 - Functional programming

https://programming-26.mooc.fi/part-12/3-functional-programming

  • thrd -> third
Part 13.1 - Pygame

https://programming-26.mooc.fi/part-13/1-pygame

Current: "The file robot.png has to be in the same directory with the source code of the your program..." Suggested: "...with the source code of your program..."

There is no need to add "the" in between "of" and "your"

Part 13.2 - Animation

https://programming-26.mooc.fi/part-13/2-animation

Current text contains 0.01:llä looks like an accidental Finnish suffix left in the English material. Suggested: 0.01, so the sentence reads "With each iteration the size of the angle is incremented by 0.01."

Part 14.2 - Robot and boxes

https://programming-26.mooc.fi/part-14/2-robot-and-boxes

  • ANyone -> Anyone
  • requiares -> requires
  • invlved -> involved
Part 14.3 - Finishing the game

https://programming-26.mooc.fi/part-14/3-finishing-the-game

  • ahve -> have
  • displaye -> displays
  • shanges -> changes
  • noification -> notification

Thanks for maintaining the course material!

Dominant language
JavaScript
Stars
77
Forks
30
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rage/programming-26

All issues in rage/programming-26

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.