rafalp/Misago

Replace thread queryset plugin hooks used by thread detail view and private thread detail views

Open

#2078 opened on May 17, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (2,409 stars) (509 forks)batch import
area: backendfeature: extensionsfeature: thread pagehelp wanted

Description

Those functions no longer exist on thread detail views:

  • get_thread_queryset
  • get_private_thread_queryset

Instead, we should implement get_thread_detail_view_select_related and get_private_thread_detail_view_select_related hooks that will take HttpRequest as only argument and return list[str].

DetailView should be updated to implement get_thread_select_related method:

def get_thread_select_related(self, request: HttpRequest) -> list[str]:
    return ["category"]

In ThreadDetailView:

def get_thread_select_related(self, request: HttpRequest) -> list[str]:
    return get_thread_detail_view_select_related_hook(super().get_thread_select_related, request)

In PrivateThreadDetailView:

def get_thread_select_related(self, request: HttpRequest) -> list[str]:
    return get_private_thread_detail_view_select_related_hook(super().get_thread_select_related, request)

get_thread calls in those detail views should be updated to self.get_thread(..., select_Related=self.get_thread_select_related(request))

Contributor guide

Tech stack
python
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Django viewsFamiliarity with plugin hooks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the current implementation of `get thread queryset` and `get private thread queryset` hooks in the codebase, likely in `misago/threads/views.py`. Then follow the instructions to implement `get thread select related` method in `DetailView` base class and override in `ThreadDetailView` and `PrivateThreadDetailView`. Update the `get thread` calls to use the new method. Check existing hook actions like `get thread detail view select related hook` and `get private thread detail view select related hook` to ensure they are correctly called.